aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPierre Labastie <pieere@linuxfromscratch.org>2020-05-31 17:33:35 +0000
committerPierre Labastie <pieere@linuxfromscratch.org>2020-05-31 17:33:35 +0000
commita3260cbb0750572691322d3524084acbd31266cd (patch)
treec031d1555be651744bd25035440927eb61dea6e3
parent5a430f193701c31f708dee38d05e63aee954cb14 (diff)
Fixes for bash tests
git-svn-id: http://svn.linuxfromscratch.org/LFS/trunk/BOOK@11881 4aa44e1e-78dd-0310-a6d2-fbcd4c07a689
-rw-r--r--chapter01/changelog.xml12
-rw-r--r--chapter06/bash.xml4
-rw-r--r--chapter06/coreutils.xml2
-rw-r--r--chapter06/createfiles.xml4
-rw-r--r--general.ent6
5 files changed, 21 insertions, 7 deletions
diff --git a/chapter01/changelog.xml b/chapter01/changelog.xml
index e06d8d271..9bfa1a9f7 100644
--- a/chapter01/changelog.xml
+++ b/chapter01/changelog.xml
@@ -43,6 +43,18 @@
appropriate for the entry or if needed the entire day's listitem.
-->
<listitem>
+ <para>2020-05-31</para>
+ <itemizedlist>
+ <listitem>
+ <para>[pierre] - Fix bash tests: add a couple of symlinks
+ from /bin to /tools, create the tester user with the uid of
+ the tty owner, run the bash tests with su &lt;&lt; EOF, and
+ explicitely defining stdin (with help from thomas and bdubbs).</para>
+ </listitem>
+ </itemizedlist>
+ </listitem>
+
+ <listitem>
<para>2020-05-29</para>
<itemizedlist>
<listitem>
diff --git a/chapter06/bash.xml b/chapter06/bash.xml
index ae42cf4cb..4d06fc2a3 100644
--- a/chapter06/bash.xml
+++ b/chapter06/bash.xml
@@ -80,7 +80,9 @@
<para>Now, run the tests as the <systemitem
class="username">tester</systemitem> user:</para>
-<screen><userinput remap="test">su tester -c "PATH=$PATH make tests"</userinput></screen>
+<screen><userinput remap="test">su tester &lt;&lt; EOF
+PATH=$PATH make tests &lt; $(tty)
+EOF</userinput></screen>
<para>The <systemitem class="username">tester</systemitem>
user does not have enough permissions for all the tests to pass. This shows
diff --git a/chapter06/coreutils.xml b/chapter06/coreutils.xml
index 78309ba32..ffef82f84 100644
--- a/chapter06/coreutils.xml
+++ b/chapter06/coreutils.xml
@@ -116,7 +116,7 @@ FORCE_UNSAFE_CONFIGURE=1 ./configure \
these tests are not skipped we'll add a temporary group and make the
user <systemitem class="username">tester</systemitem> a part of it:</para>
-<screen><userinput remap="test">echo "dummy:x:1000:tester" &gt;&gt; /etc/group</userinput></screen>
+<screen><userinput remap="test">echo "dummy:x:102:tester" &gt;&gt; /etc/group</userinput></screen>
<para>Fix some of the permissions so that the non-root user can compile and
run the tests:</para>
diff --git a/chapter06/createfiles.xml b/chapter06/createfiles.xml
index 10a906a65..cb19ce6df 100644
--- a/chapter06/createfiles.xml
+++ b/chapter06/createfiles.xml
@@ -39,7 +39,7 @@
will be replaced by real files throughout the course of this chapter after the
software has been installed:</para>
-<screen><userinput>ln -sv /tools/bin/{bash,cat,chmod,dd,echo,ln,mkdir,pwd,rm,stty,touch} /bin
+<screen><userinput>ln -sv /tools/bin/{bash,cat,chmod,dd,echo,false,ln,ls,mkdir,pwd,rm,stty,touch} /bin
ln -sv /tools/bin/{env,install,perl,printf} /usr/bin
ln -sv /tools/lib/libgcc_s.so{,.1} /usr/lib
ln -sv /tools/lib/libstdc++.{a,so{,.6}} /usr/lib
@@ -334,7 +334,7 @@ EOF</userinput></screen>
<para>Some tests later in the chapter need a regular user. We add this
user here and delete this account at the end of the chapter.</para>
-<screen><userinput>echo "tester:x:101:101::/home/tester:/bin/bash" &gt;&gt; /etc/passwd
+<screen><userinput>echo "tester:x:$(ls -n $(tty) | cut -d" " -f3):101::/home/tester:/bin/bash" &gt;&gt; /etc/passwd
echo "tester:x:101:" &gt;&gt; /etc/group
install -o tester -d /home/tester</userinput></screen>
diff --git a/general.ent b/general.ent
index 77e61b49c..47c54b421 100644
--- a/general.ent
+++ b/general.ent
@@ -1,13 +1,13 @@
-<!ENTITY version "SVN-20200529">
+<!ENTITY version "SVN-20200531">
<!ENTITY short-version "svn"> <!-- Used below in &blfs-book;
Change to x.y for release but not -rc releases -->
<!ENTITY generic-version "development"> <!-- Use "development" or "x.y[-pre{x}]" -->
-<!ENTITY versiond "20200529-systemd">
+<!ENTITY versiond "20200531-systemd">
<!ENTITY short-versiond "systemd">
<!ENTITY generic-versiond "systemd">
-<!ENTITY releasedate "May 29th, 2020">
+<!ENTITY releasedate "May 31st, 2020">
<!ENTITY copyrightdate "1999-2020"><!-- jhalfs needs a literal dash, not &ndash; -->