Implemented changes to make the running of the Chapter 5 test

suites strictly optional i.e. the default action for the
average reader is to not run them. Closes 719.


git-svn-id: http://svn.linuxfromscratch.org/LFS/trunk/BOOK@3172 4aa44e1e-78dd-0310-a6d2-fbcd4c07a689

6 files changed, 48 insertions, 36 deletions

diff --git a/chapter05/binutils-pass1.xml b/chapter05/binutils-pass1.xml
index db33530f5..43c99423a 100644
--- a/chapter05/binutils-pass1.xml
+++ b/chapter05/binutils-pass1.xml
@@ -17,11 +17,6 @@ Estimated required disk space:  &binutils-compsize-tools-pass1;</screen>
 because both Glibc and GCC perform various tests on the available linker and
 assembler to determine which of their own features to enable.</para>
 
-<note><para>Even though Binutils is an important toolchain package, we are not
-going to run the test suite at this early stage. First, the test suite framework
-is not yet in place and second, the programs from this first pass will soon be
-overwritten by those installed in the second pass.</para></note>
-
 <para>This package is known to behave badly when you have changed its default
 optimization flags (including the -march and -mcpu options). Therefore, if
 you have defined any environment variables that override default
@@ -77,6 +72,14 @@ strictly speaking, <userinput>"-all-static"</userinput> is first passed to the
 <userinput>"-static"</userinput> on to the linker.</para></listitem>
 </itemizedlist>
 
+<para>Compilation is now complete. This is the point where we would normally
+run the test suite. But as discussed earlier, we don't recommend running the
+test suites for the temporary tools here in this chapter. However, even if we
+still wanted to run the Binutils test suite, we're unable do so at this early
+stage because the test suite framework is not yet in place. Not only that, the
+programs from this first pass will soon be overwritten by those installed in
+the second pass.</para>
+
 <para>And install the package:</para>
 
 <screen><userinput>make install</userinput></screen>
diff --git a/chapter05/binutils-pass2.xml b/chapter05/binutils-pass2.xml
index f52a7ac42..7617470c4 100644
--- a/chapter05/binutils-pass2.xml
+++ b/chapter05/binutils-pass2.xml
@@ -40,16 +40,15 @@ variables that override the default optimization flags.</para>
 
 <screen><userinput>make</userinput></screen>
 
-<note><para>It's worth pointing out that running the Binutils test suite here
-is considered not as important as running it in
-<xref linkend="chapter06"/>.</para></note>
-
-<para>Test the results (there should be no unexpected failures here, expected
-failures are fine):</para>
+<para>Compilation is now complete. As discussed earlier, we don't recommend
+running the test suites for the temporary tools here in this chapter. If you
+still want to run the Binutils test suite anyway, the following command will
+do so:</para>
 
 <screen><userinput>make check</userinput></screen>
 
-<para>Unfortunately, there is no easy way to view the test results summary like
+<para>There should be no unexpected failures here, expected failures are fine.
+Unfortunately, there is no easy way to view the test results summary like
 there was for the previous GCC package. However, if a failure occurs here, it
 should be easy to spot. The output shown will contain something like:</para>
 
diff --git a/chapter05/gcc-pass1.xml b/chapter05/gcc-pass1.xml
index 6a83e9089..2ec21c6d3 100644
--- a/chapter05/gcc-pass1.xml
+++ b/chapter05/gcc-pass1.xml
@@ -18,11 +18,6 @@ Estimated required disk space:  &gcc-compsize-tools-pass1;</screen>
 <para>Unpack only the GCC-core tarball, as we won't be needing a C++ compiler
 for the moment.</para>
 
-<note><para>Even though GCC is an important toolchain package, we are not
-going to run the test suite at this early stage. First, the test suite framework
-is not yet in place and second, the programs from this first pass will soon be
-overwritten by those installed in the second pass.</para></note>
-
 <para>This package is known to behave badly when you have changed its
 default optimization flags (including the -march and -mcpu options).
 Therefore, if you have defined any environment variables that override
@@ -83,6 +78,14 @@ reproduce itself flawlessly, which most probably means that it was
 compiled correctly.</para></listitem>
 </itemizedlist>
 
+<para>Compilation is now complete. This is the point where we would normally
+run the test suite. But as discussed earlier, we don't recommend running the
+test suites for the temporary tools here in this chapter. However, even if we
+still wanted to run the GCC test suite, we're unable do so at this early stage
+because the test suite framework is not yet in place. Not only that, the
+programs from this first pass will soon be overwritten by those installed in
+the second pass.</para>
+
 <para>And install the package:</para>
 
 <screen><userinput>make install</userinput></screen>
diff --git a/chapter05/gcc-pass2.xml b/chapter05/gcc-pass2.xml
index 0e368c38a..4fe46290b 100644
--- a/chapter05/gcc-pass2.xml
+++ b/chapter05/gcc-pass2.xml
@@ -15,12 +15,12 @@ Estimated required disk space:  &gcc-compsize-tools-pass2;</screen>
 
 <para>The tools required to test GCC and Binutils are installed now (Tcl, Expect
 and DejaGnu). We can continue on rebuilding GCC and Binutils, link them against
-the new Glibc, and test them properly. One thing to note, however, is that these
-test suites are highly dependent on properly functioning pseudo terminals (PTYs)
-which are provided by your host distribution. These days, PTYs are most commonly
-implemented via the <emphasis>devpts</emphasis> file system. You can quickly
-check if your host system is set up correctly in this regard by performing a
-simple test:</para>
+the new Glibc, and test them properly (if performing the test suites in this
+chapter). One thing to note, however, is that these test suites are highly
+dependent on properly functioning pseudo terminals (PTYs) which are provided by
+your host distribution. These days, PTYs are most commonly implemented via the
+<emphasis>devpts</emphasis> file system. You can quickly check if your host
+system is set up correctly in this regard by performing a simple test:</para>
 
 <screen><userinput>expect -c "spawn ls"</userinput></screen>
 
@@ -116,11 +116,10 @@ needed to ensure that both C and C++ compilers are built.</para></listitem>
 as the compiler we're using to compile this GCC was built from the exact same
 version of the GCC sources we used earlier.</para>
 
-<note><para>It's worth pointing out that running the GCC test suite here
-is considered not as important as running it in
-<xref linkend="chapter06"/>.</para></note>
-
-<para>Test the results:</para>
+<para>Compilation is now complete. As discussed earlier, we don't recommend
+running the test suites for the temporary tools here in this chapter. If you
+still want to run the GCC test suite anyway, the following command will do
+so:</para>
 
 <screen><userinput>make -k check</userinput></screen>
 
diff --git a/chapter05/glibc.xml b/chapter05/glibc.xml
index ab61b8c9b..1f178dd15 100644
--- a/chapter05/glibc.xml
+++ b/chapter05/glibc.xml
@@ -18,11 +18,6 @@ into the <filename>glibc-&glibc-version;</filename> directory and unpack
 Glibc-linuxthreads in that directory, not in the directory where you usually
 unpack all the sources.</para>
 
-<note><para>We are going to run the test suite for Glibc in this chapter.
-However, it's worth pointing out that running the Glibc test suite here
-is considered not as important as running it in
-<xref linkend="chapter06"/>.</para></note>
-
 <para>This package is known to behave badly when you have changed its
 default optimization flags (including the -march and -mcpu options).
 Therefore, if you have defined any environment variables that override
@@ -88,7 +83,10 @@ running the test suite.</para>
 
 <screen><userinput>make</userinput></screen>
 
-<para>Run the test suite:</para>
+<para>Compilation is now complete. As discussed earlier, we don't recommend
+running the test suites for the temporary system here in this chapter. If you
+still want to run the Glibc test suite anyway, the following command will do
+so:</para>
 
 <screen><userinput>make check</userinput></screen>
 
@@ -149,7 +147,14 @@ touch /tools/etc/ld.so.conf</userinput></screen>
 communicate. These conventions range from very simple ones, such as the format
 for representing dates and times, to very complex ones, such as the language
 spoken. The "internationalization" of GNU programs works by means of
-<emphasis>locales</emphasis>. We'll install the Glibc locales now:</para>
+<emphasis>locales</emphasis>.</para>
+
+<note><para>If you are not running the test suites here in this chapter as per
+our recommendation, there is little point in installing the locales now. We'll
+be installing the locales in the next chapter.</para></note>
+
+<para>If you still want to install the Glibc locales anyway, the following
+command will do so:</para>
 
 <screen><userinput>make localedata/install-locales</userinput></screen>
 
diff --git a/chapter05/tcl.xml b/chapter05/tcl.xml
index 68336d979..73d080f4c 100644
--- a/chapter05/tcl.xml
+++ b/chapter05/tcl.xml
@@ -18,7 +18,10 @@ Estimated required disk space:  &tcl-compsize-tools;</screen>
 <para>This package and the next two are only installed to be able to run the 
 test suites for GCC and Binutils. Installing three packages just for testing 
 purposes may seem like overkill, but it is very reassuring, if not essential, 
-to know that our most important tools are working properly.</para>
+to know that our most important tools are working properly. Even if you are
+not running the test suites here in this chapter as per our recommendation,
+these packages are still required for the test suites in the next
+chapter.</para>
 
 <para>Prepare Tcl for compilation:</para>